[lkml]   [2012]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 4/8] staging: tidspbridge: silence the compiler
On Tue, Jan 31, 2012 at 11:05:43AM +0300, Dan Carpenter wrote:
> On Tue, Jan 31, 2012 at 12:12:20AM +0100, Víctor Manuel Jáquez Leal wrote:
> > Silence the warning when compiling drv_interface.c
> >
> > Signed-off-by: Víctor Manuel Jáquez Leal <>
> What does the compiler warn about here? Normally you would cut and
> paste the warning into the commit message. But at least give us a
> hint.
> You could also reformat that printk so the message is on one line.
> dev_dbg(bridge,
> "%s: vm filp %p offset %x start %lx end %lx page_prot %ulx flags %lx\n",
> __func__, filp, offset, vma->vm_start, vma->vm_end,
> vma->vm_page_prot, vma->vm_flags);

Ok. I'll do it.

I have a doubt about the process in this case: if this is the only
modification request, should I resend all the patch set, or just this one?



> regards,
> dan carpenter

[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2012-01-31 12:23    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean