[lkml]   [2012]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] fix readahead pipeline break caused by block plug
On Tue, Jan 31, 2012 at 06:34:16PM +0800, Wu Fengguang wrote:
> }
> + blk_start_plug(&plug);
> written = mapping->a_ops->direct_IO(WRITE, iocb, iov, pos, *nr_segs);
> + blk_finish_plug(&plug);

Please move the plugging into ->direct_IO for both read and write, as
that is the boundary between generic highlevel code, and low-level block
code that should know about plugs.

 \ /
  Last update: 2012-01-31 11:49    [W:0.130 / U:1.264 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site