lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 7/8] staging: tidspbridge: clean up bridge_mmap()
    Date
    The variable offset is not used but in the debug log, so I don't see reason to
    calculate it here.

    Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
    ---
    drivers/staging/tidspbridge/rmgr/drv_interface.c | 5 ++---
    1 files changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c b/drivers/staging/tidspbridge/rmgr/drv_interface.c
    index 97c40ff..5f810b6 100644
    --- a/drivers/staging/tidspbridge/rmgr/drv_interface.c
    +++ b/drivers/staging/tidspbridge/rmgr/drv_interface.c
    @@ -257,7 +257,6 @@ err:
    /* This function maps kernel space memory to user space memory. */
    static int bridge_mmap(struct file *filp, struct vm_area_struct *vma)
    {
    - u32 offset = vma->vm_pgoff << PAGE_SHIFT;
    u32 status;

    DBC_ASSERT(vma->vm_start < vma->vm_end);
    @@ -265,8 +264,8 @@ static int bridge_mmap(struct file *filp, struct vm_area_struct *vma)
    vma->vm_flags |= VM_RESERVED | VM_IO;
    vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);

    - dev_dbg(bridge, "%s: vm filp %p offset %x start %lx end %lx page_prot "
    - "%ulx flags %lx\n", __func__, filp, offset,
    + dev_dbg(bridge, "%s: vm filp %p start %lx end %lx page_prot %ulx "
    + "flags %lx\n", __func__, filp,
    vma->vm_start, vma->vm_end, vma->vm_page_prot,
    vma->vm_flags);

    --
    1.7.8.3
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-01-31 00:15    [W:0.027 / U:0.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site