lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] staging: rts5139: Fixed coding style issues
    On Mon, 30 Jan 2012, Autif Khan wrote:

    >
    > Signed-off-by: Autif Khan <autfk@gmail.com>

    Yeah, looks OK.

    Reviewed-by: Jesper Juhl <jj@chaosbits.net>


    > ---
    > drivers/staging/rts5139/ms.h | 4 ++--
    > drivers/staging/rts5139/rts51x_chip.h | 6 +++---
    > drivers/staging/rts5139/rts51x_fop.h | 2 +-
    > drivers/staging/rts5139/rts51x_transport.c | 2 +-
    > drivers/staging/rts5139/rts51x_transport.h | 2 +-
    > drivers/staging/rts5139/sd_cprm.c | 2 +-
    > 6 files changed, 9 insertions(+), 9 deletions(-)
    >
    > diff --git a/drivers/staging/rts5139/ms.h b/drivers/staging/rts5139/ms.h
    > index f9d46d2..3ce1dc9 100644
    > --- a/drivers/staging/rts5139/ms.h
    > +++ b/drivers/staging/rts5139/ms.h
    > @@ -249,9 +249,9 @@ int ms_delay_write(struct rts51x_chip *chip);
    > #ifdef SUPPORT_MAGIC_GATE
    >
    > int ms_switch_clock(struct rts51x_chip *chip);
    > -int ms_write_bytes(struct rts51x_chip *chip, u8 tpc, u8 cnt, u8 cfg, u8 * data,
    > +int ms_write_bytes(struct rts51x_chip *chip, u8 tpc, u8 cnt, u8 cfg, u8 *data,
    > int data_len);
    > -int ms_read_bytes(struct rts51x_chip *chip, u8 tpc, u8 cnt, u8 cfg, u8 * data,
    > +int ms_read_bytes(struct rts51x_chip *chip, u8 tpc, u8 cnt, u8 cfg, u8 *data,
    > int data_len);
    > int ms_set_rw_reg_addr(struct rts51x_chip *chip, u8 read_start, u8 read_cnt,
    > u8 write_start, u8 write_cnt);
    > diff --git a/drivers/staging/rts5139/rts51x_chip.h b/drivers/staging/rts5139/rts51x_chip.h
    > index 321ece7..13fc2a4 100644
    > --- a/drivers/staging/rts5139/rts51x_chip.h
    > +++ b/drivers/staging/rts5139/rts51x_chip.h
    > @@ -857,12 +857,12 @@ static inline u8 *rts51x_get_rsp_data(struct rts51x_chip *chip)
    > return chip->rsp_buf;
    > }
    >
    > -int rts51x_get_card_status(struct rts51x_chip *chip, u16 * status);
    > +int rts51x_get_card_status(struct rts51x_chip *chip, u16 *status);
    > int rts51x_write_register(struct rts51x_chip *chip, u16 addr, u8 mask, u8 data);
    > -int rts51x_read_register(struct rts51x_chip *chip, u16 addr, u8 * data);
    > +int rts51x_read_register(struct rts51x_chip *chip, u16 addr, u8 *data);
    > int rts51x_ep0_write_register(struct rts51x_chip *chip, u16 addr, u8 mask,
    > u8 data);
    > -int rts51x_ep0_read_register(struct rts51x_chip *chip, u16 addr, u8 * data);
    > +int rts51x_ep0_read_register(struct rts51x_chip *chip, u16 addr, u8 *data);
    > int rts51x_seq_write_register(struct rts51x_chip *chip, u16 addr, u16 len,
    > u8 *data);
    > int rts51x_seq_read_register(struct rts51x_chip *chip, u16 addr, u16 len,
    > diff --git a/drivers/staging/rts5139/rts51x_fop.h b/drivers/staging/rts5139/rts51x_fop.h
    > index 0453f57..94d75f0 100644
    > --- a/drivers/staging/rts5139/rts51x_fop.h
    > +++ b/drivers/staging/rts5139/rts51x_fop.h
    > @@ -48,7 +48,7 @@ int rts51x_open(struct inode *inode, struct file *filp);
    > int rts51x_release(struct inode *inode, struct file *filp);
    > ssize_t rts51x_read(struct file *filp, char __user *buf, size_t count,
    > loff_t *f_pos);
    > -ssize_t rts51x_write(struct file *filp, const char __user * buf, size_t count,
    > +ssize_t rts51x_write(struct file *filp, const char __user *buf, size_t count,
    > loff_t *f_pos);
    > #if 0 /* LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 36) */
    > int rts51x_ioctl(struct inode *inode, struct file *filp, unsigned int cmd,
    > diff --git a/drivers/staging/rts5139/rts51x_transport.c b/drivers/staging/rts5139/rts51x_transport.c
    > index e11467a..da9c83b 100644
    > --- a/drivers/staging/rts5139/rts51x_transport.c
    > +++ b/drivers/staging/rts5139/rts51x_transport.c
    > @@ -883,7 +883,7 @@ int rts51x_transfer_data_partial(struct rts51x_chip *chip, unsigned int pipe,
    > return result;
    > }
    >
    > -int rts51x_get_epc_status(struct rts51x_chip *chip, u16 * status)
    > +int rts51x_get_epc_status(struct rts51x_chip *chip, u16 *status)
    > {
    > unsigned int pipe = RCV_INTR_PIPE(chip);
    > struct usb_host_endpoint *ep;
    > diff --git a/drivers/staging/rts5139/rts51x_transport.h b/drivers/staging/rts5139/rts51x_transport.h
    > index 8464c48..9dd556e 100644
    > --- a/drivers/staging/rts5139/rts51x_transport.h
    > +++ b/drivers/staging/rts5139/rts51x_transport.h
    > @@ -73,7 +73,7 @@ int rts51x_start_epc_transfer(struct rts51x_chip *chip);
    > void rts51x_cancel_epc_transfer(struct rts51x_chip *chip);
    > #endif
    >
    > -int rts51x_get_epc_status(struct rts51x_chip *chip, u16 * status);
    > +int rts51x_get_epc_status(struct rts51x_chip *chip, u16 *status);
    > void rts51x_invoke_transport(struct scsi_cmnd *srb, struct rts51x_chip *chip);
    >
    > #endif /* __RTS51X_TRANSPORT_H */
    > diff --git a/drivers/staging/rts5139/sd_cprm.c b/drivers/staging/rts5139/sd_cprm.c
    > index 407cd43..d5969d9 100644
    > --- a/drivers/staging/rts5139/sd_cprm.c
    > +++ b/drivers/staging/rts5139/sd_cprm.c
    > @@ -233,7 +233,7 @@ RTY_SEND_CMD:
    > return STATUS_SUCCESS;
    > }
    >
    > -int ext_sd_get_rsp(struct rts51x_chip *chip, int len, u8 * rsp, u8 rsp_type)
    > +int ext_sd_get_rsp(struct rts51x_chip *chip, int len, u8 *rsp, u8 rsp_type)
    > {
    > int retval, rsp_len;
    > u16 reg_addr;
    >

    --
    Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
    Don't top-post http://www.catb.org/jargon/html/T/top-post.html
    Plain text mails only, please.



    \
     
     \ /
      Last update: 2012-01-30 22:31    [W:0.034 / U:0.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site