lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/5] TTY: pty, remove superfluous ptm test
    On Mon, 30 Jan 2012 21:14:31 +0100
    Jiri Slaby <jslaby@suse.cz> wrote:

    > The code looks like:
    > if (tty->driver->subtype == PTY_TYPE_MASTER) {
    > ...
    > if (tty->driver == ptm_driver)
    >
    > But the second if is superfluous because only the ptm_driver is of
    > PTY_TYPE_MASTER subtype.
    >
    > Also we can remove the #if now because devpts_pty_kill is defined as
    > an empty function for non-CONFIG_UNIX98_PTYS configs.
    >
    > Signed-off-by: Jiri Slaby <jslaby@suse.cz>

    Acked-by: Alan Cox <alan@linux.intel.com>


    \
     
     \ /
      Last update: 2012-01-30 21:39    [W:0.021 / U:0.340 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site