Messages in this thread | | | Date | Mon, 30 Jan 2012 18:04:32 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf: fix broken perf inject -b |
| |
Em Mon, Jan 30, 2012 at 08:53:26PM +0100, Stephane Eranian escreveu: > On Mon, Jan 30, 2012 at 8:00 PM, Arnaldo Carvalho de Melo > <acme@redhat.com> wrote: > > > > Em Mon, Jan 16, 2012 at 07:53:28PM +0100, Stephane Eranian escreveu: > > > On Fri, Jan 13, 2012 at 5:54 PM, Stephane Eranian <eranian@google.com> wrote: > > > > On Fri, Jan 13, 2012 at 5:53 PM, Arnaldo Carvalho de Melo <acme@redhat.com> wrote: > > > >> Em Fri, Jan 13, 2012 at 03:47:31PM +0100, Stephane Eranian escreveu: > > > >>> perf inject -b was broken. It would not inject any build_ids > > > >>> into the stream. Furthermore, it would strip samples from the > > > >>> stream. > > <SNIP> > > > >>> @@ -173,6 +178,7 @@ static int perf_event__inject_buildid(struct perf_tool *tool, > > > >>> goto repipe; > > > >>> } > > > >>> + machine->pid = event->ip.pid; > > > > > I noticed that this statement conflicts with perf buildid-list (which > > > I am also fixing for pipe mode). > > > > > I don't quite understand why, though. > > > > Have you reached any conclusion about this problem? I haven't looked at > > it in detail, could you please elaborate more? > > > > I ended up removing it. But I am not sure this is correct. > Is the pid used in any way when processing buildids?
I can't think of any.
The same DSO could conceivably be present in the virtual machine, the host, and in the workstation used for perf report. We just use the build-id in the perf.data file to find the right symtab.
- Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |