lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 10/13] PCI: Strict checking of valid range for bridge
From
On Mon, Jan 30, 2012 at 8:04 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Fri, Jan 27, 2012 at 6:49 PM, Yinghai Lu <yinghai@kernel.org> wrote:
>> children bridges busn range should be able to be allocated from parent bus range.
>>
>> to avoid overlapping between sibling bridges on same bus.
>>
>> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>> ---
>>  drivers/pci/probe.c |   27 +++++++++++++++++++++++++++
>>  1 files changed, 27 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
>> index 83df3fb..e12f65f0 100644
>> --- a/drivers/pci/probe.c
>> +++ b/drivers/pci/probe.c
>> @@ -791,6 +791,33 @@ reduce_needed_size:
>>        return ret;
>>  }
>>
>> +static int __devinit pci_bridge_check_busn_res(struct pci_bus *bus,
>> +                               struct pci_dev *dev,
>> +                               int secondary, int subordinate)
>
> This function returns a boolean, but the function name doesn't give
> any clue about what a true/false return means.  Something like
> "busn_valid" would make the callers more readable.

ok

>
>> +{
>> +       int broken = 0;
>> +
>> +       struct resource busn_res;
>> +       int ret;
>> +
>> +       memset(&busn_res, 0, sizeof(struct resource));
>> +       dev_printk(KERN_DEBUG, &dev->dev,
>> +                "check if busn %02x-%02x is in busn_res: %06llx-%06llx\n",
>> +                secondary, subordinate,
>> +                (unsigned long long)bus->busn_res.start,
>> +                (unsigned long long)bus->busn_res.end);
>> +       ret = allocate_resource(&bus->busn_res, &busn_res,
>> +                        (subordinate - secondary + 1),
>> +                        (pci_domain_nr(bus)<<8) | secondary,
>> +                        (pci_domain_nr(bus)<<8) | subordinate,
>
> I think this "(pci_domain_nr(bus)<<8) | secondary" stuff needs to be a
> macro or something.

maybe.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-01-30 19:55    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site