lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Slab corruption in floppy driver module
On 01/30/2012 01:06 AM, Tejun Heo wrote:
> On Fri, Jan 27, 2012 at 02:54:55PM -0500, Vivek Goyal wrote:
>> floppy: Fix a crash during rmmmod
>>
>> floppy driver does not call add_disk() on all the drives hence we don't take
>> gendisk reference on request queue for these drives. Don't call put_disk()
>> with disk->queue set, otherwise we try to put the reference we never took.
>>
>> Reported-by: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
>> Signed-off-by: Vivek Goyal<vgoyal@redhat.com>
>
> Ugh... floppy init is ugly. Thanks for fixing this.
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> Jens, this one and the previous one are regression fixes and need to
> be routed through v3.3-fixes.
>

Looks like it needs to be marked for -stable as well as the commit
f992ae8 which exposed these problems was originally marked for -stable?


Suresh


\
 
 \ /
  Last update: 2012-01-30 07:07    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site