lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: checkpatch.pl: WxV false positive
    On Sun, Jan 22, 2012 at 09:48:34PM -0500, Vivien Didelot wrote:

    > In the code below, checkpatch thinks that the asterisk is a
    > multiplication, so it is complaining about coding style.
    >
    > ERROR: need consistent spacing around '*' (ctx:WxV)
    > #304: FILE: x86/platform/ts5500/ts5500_adc.c:304:
    > + .attrs = (struct attribute *[]) {

    C types are the pits. How does the version below handle for you:

    http://people.canonical.com/~apw/checkpatch/checkpatch-next.pl

    Relative patch below.

    -apw

    commit f8a73045dcaac70f9be770cca06f21c762a13878
    Author: Andy Whitcroft <apw@canonical.com>
    Date: Sun Jan 29 21:46:04 2012 +0000

    checkpatch: add [] to type extensions

    Add [] to a type extensions. Fixes false positives on:

    .attrs = (struct attribute *[]) {

    Signed-off-by: Andy Whitcroft <apw@canonical.com>

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index d1dd544..64de1bd 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -323,7 +323,7 @@ sub build_types {
    }x;
    $Type = qr{
    $NonptrType
    - (?:[\s\*]+\s*const|[\s\*]+|(?:\s*\[\s*\])+)?
    + (?:(?:\s|\*|\[\])+\s*const|(?:\s|\*|\[\])+|(?:\s*\[\s*\])+)?
    (?:\s+$Inline|\s+$Modifier)*
    }x;
    $Declare = qr{(?:$Storage\s+)?$Type};

    \
     
     \ /
      Last update: 2012-01-30 12:21    [W:0.021 / U:150.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site