lkml.org 
[lkml]   [2012]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc)
On Thu, Dec 15, 2011 at 01:48:51PM +1030, Rusty Russell wrote:
> diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c
> --- a/drivers/block/paride/pcd.c
> +++ b/drivers/block/paride/pcd.c
> @@ -105,13 +105,14 @@
> #define PCD_NAME "pcd"
> #define PCD_UNITS 4
>
> +#include <linux/types.h>
> /* Here are things one can override from the insmod command.
> Most are autoprobed by paride unless set here. Verbose is off
> by default.
>
> */
>
> -static int verbose = 0;
> +static bool verbose = 0;

This should be int. Verbose can be set to 2 for extra verbosity.

Btw, these patches that touch a ton of drivers are the wrong idea.
If you ack any part of it, then get_maintainer.pl CCs you on every
single kernel patch until eventually you get old and die.

regards,
dan carpenter
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-01-03 14:01    [from the cache]
©2003-2011 Jasper Spaans