[lkml]   [2012]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC][PATCH 0/4] lcd: platform-lcd: Add lcd panel and device tree support
    On 01/02/2012 06:54 AM, Thomas Abraham wrote:
    > The platform-lcd driver depends on platform-specific callbacks to setup the
    > lcd panel. These callbacks are supplied using driver's platform data. But
    > for adding device tree support for platform-lcd driver, providing such
    > callbacks is not possible (without using auxdata).
    > Since the callbacks are usually lcd panel specific, it is possible to include
    > the lcd panel specific setup and control functionality in the platform-lcd
    > driver itself, thereby eliminating the need for supplying platform specific
    > callbacks to the driver. The platform-lcd driver can include support for
    > multiple lcd panels.
    > This patchset removes the need for platform data for platform-lcd driver and
    > adds support which can be used to implement lcd panel specific functionality
    > in the driver. As an example, the support for Hydis hv070wsa lcd panel is added
    > to the platform-lcd driver which is then used on the Exynos4 based Origen board.
    > This currently breaks build for other users of platform-lcd driver. Those can be
    > fixed if this approach is acceptable.

    The whole approach looks rather backwards to me. The exact purpose of the
    platform_lcd driver is to redirect the lcd driver callbacks to board code.
    So by removing this support you not only break all the existing driver but
    also create a driver which does nothing. Then you add another layer of
    abstraction to implement custom drivers in this driver. A better approach in
    my opinion is to simply implement these drivers as first level LCD drivers.
    So leave the platform-lcd driver as it is and just add a gpio (or maybe
    regulator) lcd driver instead.

    - Lars

     \ /
      Last update: 2012-01-03 10:09    [W:0.021 / U:5.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site