lkml.org 
[lkml]   [2012]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] rtc: twl: optimize IRQ bit access
> -----Original Message-----
> From: Andrew Morton [mailto:akpm@linux-foundation.org]
> Sent: Saturday, January 28, 2012 6:09 AM
> To: Venu Byravarasu
> Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] rtc: twl: optimize IRQ bit access
>
> Are these functions called frequently enough to make this optimisation
> significant?
I did not check how frequent these functions are called.
However, as the values are cached any way, thought of using them before doing hardware access.
>
> I can see no locking protecting rtc_irq_bits from concurrent updaters.
> Is this code as racy as it appears?
Yes, looks like it is. Will push a separate patch to fix this issue.



\
 
 \ /
  Last update: 2012-01-30 04:21    [W:0.045 / U:1.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site