Messages in this thread | | | From | Venu Byravarasu <> | Date | Mon, 30 Jan 2012 08:47:59 +0530 | Subject | RE: [PATCH] rtc: twl: optimize IRQ bit access |
| |
> -----Original Message----- > From: Andrew Morton [mailto:akpm@linux-foundation.org] > Sent: Saturday, January 28, 2012 6:09 AM > To: Venu Byravarasu > Cc: a.zummo@towertech.it; rtc-linux@googlegroups.com; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH] rtc: twl: optimize IRQ bit access > > Are these functions called frequently enough to make this optimisation > significant? I did not check how frequent these functions are called. However, as the values are cached any way, thought of using them before doing hardware access. > > I can see no locking protecting rtc_irq_bits from concurrent updaters. > Is this code as racy as it appears? Yes, looks like it is. Will push a separate patch to fix this issue.
| |