lkml.org 
[lkml]   [2012]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] net5501: platform driver for Soekris Engineering net5501 single-board computer
On Sat, 31 Dec 2011 02:28:42 -0700
Philip Prindeville <philipp@redfish-solutions.com> wrote:

> From: "Philip A. Prindeville" <philipp@redfish-solutions.com>
>
> Trivial platform driver for Soekris Engineering net5501 single-board
> computer. Probes well-known locations in ROM for BIOS signature to
> confirm correct platform. Registers 1 LED and 1 GPIO-based button
> (typically used for soft reset).
>
>
> ...
>
> +static int __init net5501_present(void)
> +{
> + int i;
> + unsigned char *rombase, *bios;
> +
> + rombase = ioremap(BIOS_REGION_BASE, BIOS_REGION_SIZE - 1);
> + if (!rombase)
> + printk(KERN_INFO "Soekris net5501 LED driver failed to get rombase");

It seems wrong to continue if ioremap() failed. It should return
-ENOMEM here. And perhaps boost the KERN_INFO to KERN_ERR?

> + bios = rombase + 0x20; /* null terminated */
> +
> + if (memcmp(bios, "comBIOS", 7))
> + goto unmap;
> +
> + for (i = 0; i < ARRAY_SIZE(boards); i++) {
> + unsigned char *model = rombase + boards[i].offset;
> +
> + if (memcmp(model, boards[i].sig, boards[i].len) == 0) {
> + printk(KERN_INFO "Soekris %s: %s\n", model, bios);
> +
> + register_net5501();
> + break;
> + }
> + }
> +
> +unmap:
> + iounmap(rombase);
> + return 0;
> +}
> +
> +static int __init net5501_init(void)
> +{
> + if (!is_geode())
> + return 0;
> +
> + if (net5501_present())
> + register_net5501();

This makes no sense. net5501_present() always returns zero so
register_net5501() is never called. net5501_present() itself calls
register_net5501(), so perhaps this is just dead code.

It seems cleaner to me to do the register_net5501() call from
net5501_init(). A function called "foo_present()" should test for the
presence of foo (and return a bool!) - we don't expect it to run off
and register things.

I assume this code is all runtime tested?

>
> ...
>



\
 
 \ /
  Last update: 2012-01-28 00:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site