Messages in this thread | | | Date | Fri, 27 Jan 2012 12:37:13 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [RFC c/r 2/4] [RFC] syscalls, x86: Add __NR_kcmp syscall v7 |
| |
On 01/27/2012 12:34 PM, Glauber Costa wrote: >>> + case KCMP_SYSVSEM: >>> +#ifdef CONFIG_SYSVIPC >>> + ret = kcmp_ptr((long)task1->sysvsem.undo_list, >>> + (long)task2->sysvsem.undo_list, >>> + KCMP_SYSVSEM); >>> +#else >>> + ret = -EINVAL; >> >> ENOTSUP is better, I think. because of, EINVAL implicitly mean _caller_ is wrong. >> but in this case, it is not bad. only the kernel doesn't have enough feature. >> > > Isn't it usually the case for ENOSYS, then ? >
ENOSYS means "no such system call". That would apply if the kcmp system call itself did not exist.
-hpa
| |