lkml.org 
[lkml]   [2012]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH] xfs: pass KM_SLEEP flag to kmem_realloc() in xlog_recover_add_to_cnt_trans()
    On Fri, Jan 27, 2012 at 03:37:26PM +0900, Mitsuo Hayasaka wrote:
    > The kmem_realloc() in xfs is given KM_* memory allocation flags. And it
    > allocates memory using kmalloc() after they are converted to gfp_mask
    > flags. In xlog_recover_add_to_cont_trans(), 0u is passed to kmem_realloc(),
    > instead of them. I guess it is preferred to use them, and here memory must
    > be allocated but don't have to be done with GFP_ATOMIC. So, this patch
    > changes it to KM_SLEEP.

    Looks good. I actually just noticed it when changing the kmem_realloc
    implementation, but let's put your patch in before that and send it off
    to Linus ASAP.

    Reviewed-by: Christoph Hellwig <hch@lst.de>


    \
     
     \ /
      Last update: 2012-01-27 11:55    [W:0.021 / U:120.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site