Messages in this thread | | | Date | Thu, 26 Jan 2012 13:39:00 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH] hwmon: (SHT15) fix bad error code |
| |
On Thu, Jan 26, 2012 at 03:59:00PM -0500, Vivien Didelot wrote: > When no platform data was supplied, returned error code was 0. > > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> > --- > drivers/hwmon/sht15.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/hwmon/sht15.c b/drivers/hwmon/sht15.c > index fe4104c..5357925 100644 > --- a/drivers/hwmon/sht15.c > +++ b/drivers/hwmon/sht15.c > @@ -883,7 +883,7 @@ static int sht15_invalidate_voltage(struct notifier_block *nb, > > static int __devinit sht15_probe(struct platform_device *pdev) > { > - int ret = 0; > + int ret; > struct sht15_data *data = kzalloc(sizeof(*data), GFP_KERNEL); > u8 status = 0; > > @@ -901,6 +901,7 @@ static int __devinit sht15_probe(struct platform_device *pdev) > init_waitqueue_head(&data->wait_queue); > > if (pdev->dev.platform_data == NULL) { > + ret = -EINVAL; > dev_err(&pdev->dev, "no platform data supplied\n"); > goto err_free_data; > } > -- > 1.7.6.5 > Good catch. Applied.
Thanks, Guenter
| |