lkml.org 
[lkml]   [2012]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] iommu/msm: Fix error handling in msm_iommu_unmap()
    Date
    Error handling in msm_iommu_unmap() is broken. On some error
    conditions retval is set to a non-zero value which causes
    the function to return 'len' at the end. This hides the
    error from the user. Zero should be returned in those error
    cases.

    Cc: David Brown <davidb@codeaurora.org>
    Cc: Stepan Moskovchenko <stepanm@codeaurora.org>
    Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
    ---
    drivers/iommu/msm_iommu.c | 7 +------
    1 files changed, 1 insertions(+), 6 deletions(-)

    diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c
    index 08a90b8..cee307e 100644
    --- a/drivers/iommu/msm_iommu.c
    +++ b/drivers/iommu/msm_iommu.c
    @@ -482,23 +482,19 @@ static size_t msm_iommu_unmap(struct iommu_domain *domain, unsigned long va,

    priv = domain->priv;

    - if (!priv) {
    - ret = -ENODEV;
    + if (!priv)
    goto fail;
    - }

    fl_table = priv->pgtable;

    if (len != SZ_16M && len != SZ_1M &&
    len != SZ_64K && len != SZ_4K) {
    pr_debug("Bad length: %d\n", len);
    - ret = -EINVAL;
    goto fail;
    }

    if (!fl_table) {
    pr_debug("Null page table\n");
    - ret = -EINVAL;
    goto fail;
    }

    @@ -507,7 +503,6 @@ static size_t msm_iommu_unmap(struct iommu_domain *domain, unsigned long va,

    if (*fl_pte == 0) {
    pr_debug("First level PTE is 0\n");
    - ret = -ENODEV;
    goto fail;
    }

    --
    1.7.5.4



    \
     
     \ /
      Last update: 2012-01-26 18:33    [W:0.023 / U:31.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site