lkml.org 
[lkml]   [2012]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap


Am 26.01.2012 12:05, schrieb Wolfram Sang:
>> @@ -666,18 +666,19 @@ static int mxs_saif_probe(struct platform_device *pdev)
>> goto failed_get_resource;
>> }
>>
>> - if (!request_mem_region(iores->start, resource_size(iores),
>> - "mxs-saif")) {
>> + if (!devm_request_mem_region(&pdev->dev, iores->start,
>> + resource_size(iores), "mxs-saif")) {
>> dev_err(&pdev->dev, "request_mem_region failed\n");
>> ret = -EBUSY;
>> goto failed_get_resource;
>> }
>>
>> - saif->base = ioremap(iores->start, resource_size(iores));
>> + saif->base = devm_ioremap(&pdev->dev, iores->start,
>> + resource_size(iores));
>
> devm_request_and_ioremap() to save even more code?
>

hi all,
at first I am NOT the maintainer ...

personally i would stay with Julia's patch and add devm_request_and_ioremap() in a second round.
The devm stuff is brand new, and two steps here would allow to spot/locate problems more easy
since structural changes are less intrusive in each step.

re,
wh






\
 
 \ /
  Last update: 2012-01-26 12:59    [W:0.153 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site