lkml.org 
[lkml]   [2012]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [v2] Re: [091/129] block: fail SCSI passthrough ioctls on partition devices
    On Wed, Jan 25, 2012 at 06:10:47PM -0500, Josh Boyer wrote:
    > On Wed, Jan 25, 2012 at 5:51 PM, Sven-Haegar Koch <haegar@sdinet.de> wrote:
    > > On Wed, 25 Jan 2012, Greg KH wrote:
    > >
    > >> On Tue, Jan 24, 2012 at 05:43:50PM +0100, Paolo Bonzini wrote:
    > >> > > You need to return -ENOTTY from scsi_verify_blk_ioctl and -ENOIOCTLCMD from
    > >> > > sd_compat_ioctl, because -ENOIOCTLCMD will not be handled correctly by
    > >> > > block/ioctl.c.  This would break BLKROSET and BLKFLSBUF done by non-root
    > >> > > but with the appropriate capabilities.
    > >> > >
    > >> > > Fixed patch follows.  If you prefer that I send an interdiff, let me know.
    > >>
    > >> Wait, why do you want the stable trees to diverge from what is in
    > >> Linus's tree with regards to the error codes being returned?
    > >>
    > >> That doesn't seem safe, or sane.
    > >>
    > >> So for now, I'm going to follow what is in Linus's tree.  If you
    > >> need/want the error codes to be different, then shouldn't it also be
    > >> done there as well?
    > >
    > > May be because the stable trees do not have
    > > 07d106d0a33d6063d2061305903deb02489eba20? "vfs: fix up ENOIOCTLCMD error
    > > handling"?
    >
    > I believe that is the case, yes. Linus was unhappy about ENOIOCTLCMD vs.
    > ENOTTY overall when the patch was first submitted, which lead to that commit.
    > The patches Paolo submitted for stable are the original versions that apply
    > directly to 3.2 and older.
    >
    > 07d106d0a isn't really stable material as it was put into 3.3 to catch any odd
    > fallout from the change.

    Ok, thanks both of you, that makes more sense now. I'll take Paolo's
    updated patches and do a release now.

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-01-26 01:11    [W:0.051 / U:61.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site