lkml.org 
[lkml]   [2012]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] kbuild: disable -Wmissing-field-initializers for W=1
    On Mon, Jan 23, 2012 at 10:18:34PM +0100, Michal Marek wrote:
    > On Mon, Jan 23, 2012 at 05:54:10AM +0200, Kirill A. Shutemov wrote:
    > > -Wmissing-field-initializers is too noisy to be useful on W=1. Let's
    > > move it to W=2.
    > >
    > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    > > ---
    > > scripts/Makefile.build | 3 ++-
    > > 1 files changed, 2 insertions(+), 1 deletions(-)
    > >
    > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build
    > > index d2b366c..1535a2f 100644
    > > --- a/scripts/Makefile.build
    > > +++ b/scripts/Makefile.build
    > > @@ -62,7 +62,7 @@ endif
    > > ifdef KBUILD_ENABLE_EXTRA_GCC_CHECKS
    > > warning- := $(empty)
    > >
    > > -warning-1 := -Wextra -Wunused -Wno-unused-parameter
    > > +warning-1 := -Wextra -Wunused -Wno-unused-parameter -Wno-missing-field-initializers
    >
    > I would use $(call cc-disable-warning, missing-field-initializers), so
    > that W=1 has a chance of working with gcc 3.x.

    Something like this?

    ---

    From 9ee1c7006d14efddcb7cd52053b97aa39edf6ec3 Mon Sep 17 00:00:00 2001
    From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
    Date: Mon, 23 Jan 2012 04:59:28 +0200
    Subject: [PATCH] kbuild: disable -Wmissing-field-initializers for W=1

    -Wmissing-field-initializers is too noisy to be useful on W=1. Let's
    move it to W=2.

    Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    ---
    scripts/Makefile.build | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/scripts/Makefile.build b/scripts/Makefile.build
    index d2b366c..ff1720d 100644
    --- a/scripts/Makefile.build
    +++ b/scripts/Makefile.build
    @@ -69,6 +69,7 @@ warning-1 += -Wmissing-prototypes
    warning-1 += -Wold-style-definition
    warning-1 += $(call cc-option, -Wmissing-include-dirs)
    warning-1 += $(call cc-option, -Wunused-but-set-variable)
    +warning-1 += $(call cc-disable-warning, missing-field-initializers)

    warning-2 := -Waggregate-return
    warning-2 += -Wcast-align
    @@ -76,6 +77,7 @@ warning-2 += -Wdisabled-optimization
    warning-2 += -Wnested-externs
    warning-2 += -Wshadow
    warning-2 += $(call cc-option, -Wlogical-op)
    +warning-2 += $(call cc-option, -Wmissing-field-initializers)

    warning-3 := -Wbad-function-cast
    warning-3 += -Wcast-qual
    --
    1.7.8.3

    --
    Kirill A. Shutemov
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-01-24 12:13    [W:0.033 / U:31.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site