lkml.org 
[lkml]   [2012]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: linux-next: Tree for Jan 20 (drivers/media/radio/wl128x/)
    From
    On Sat, Jan 21, 2012 at 01:32, Randy Dunlap <rdunlap@xenotime.net> wrote:
    > On 01/19/2012 06:12 PM, Stephen Rothwell wrote:
    >> Changes since 20120119:
    >
    > on x86_64:
    >
    > ERROR: "st_register" [drivers/media/radio/wl128x/fm_drv.ko] undefined!
    > ERROR: "st_unregister" [drivers/media/radio/wl128x/fm_drv.ko] undefined!

    Also in m68k allmodconfig since a while:
    http://kisskb.ellerman.id.au/kisskb/buildresult/5427875/

    config RADIO_WL128X
    tristate "Texas Instruments WL128x FM Radio"
    depends on VIDEO_V4L2 && RFKILL
    select TI_ST if NET && GPIOLIB

    config TI_ST
    tristate "Shared transport core driver"
    depends on NET && GPIOLIB
    select FW_LOADER

    On m68k allmodconfig, GPIOLIB is not enabled, hence TI_ST
    will not be selected, and st_{,un}register() won't be there.
    Shouldn't the whole RADIO_WL128X depend on NET && GPIOLIB?
    Or depend on TI_ST, instead of selecting it?

    BTW, shouldn't it be called ti_st_un{,un}register()?
    At first I thought the link error was related to SCSI tape drives ;-)

    Gr{oetje,eeting}s,

                            Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
                                    -- Linus Torvalds
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-01-24 22:35    [W:0.020 / U:120.844 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site