lkml.org 
[lkml]   [2012]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap
    On Tue, 24 Jan 2012, Mark Brown wrote:

    > On Tue, Jan 24, 2012 at 06:29:13PM +0100, Julia Lawall wrote:
    >
    >> if (IS_ERR(saif->clk)) {
    >> - ret = PTR_ERR(saif->clk);
    >> dev_err(&pdev->dev, "Cannot get the clock: %d\n",
    >> ret);
    >> - goto failed_clk;
    >> + return PTR_ERR(saif->clk);
    >
    > Looks like the transformation is overly enthusiastic here - the
    > assignment to ret is removed but ret is used in the log message.

    Uh, no, I did that stupid thing by hand. I'll fix it. Thanks.

    julia


    \
     
     \ /
      Last update: 2012-01-24 21:39    [W:0.030 / U:0.100 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site