[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [patch v1, kernel version 3.2.1] Source mode for macvlan interaface
    Le lundi 23 janvier 2012 à 13:30 +0100, Stefan Gula a écrit :
    > From: Stefan Gula <>
    > New mode of macvlan interface called "source" allows one to specify,
    > which frames are allowed to be received by given macvlan interface.
    > This logic is used only on received frames on underlaying interface.
    > The ability to send frames from macvlan interface through underlaying
    > interface is not modified. This feature allows one to simulate 802.1x
    > mac based VLAN bahaviour by using proper netlink message to configure
    > this behavior with utililty such as "ip link" from iproute2 suite.
    > Signed-off-by: Stefan Gula <>

    Please limit line lengths to 70 chars.

    I dont understand your patch description at all, and reading its body I
    still dont understand its purpose.

    Is it sort of firewall rules (ebtable) or bridging code ?

    > +static void macvlan_hash_del_sources(struct macvlan_source_list *list,
    > + bool sync)
    > +{
    > + hlist_del_rcu(&list->hlist);
    > + kfree_rcu(list, rcu);
    > + if (sync)
    > + synchronize_rcu();
    > +}
    > +

    Please explain why are you using synchronize_rcu() here, as there must
    be a good reason, but I missed it.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2012-01-23 15:15    [W:0.021 / U:10.232 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site