lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/7] PCI: Make sriov work with hotplug remove
From
On Mon, Jan 23, 2012 at 11:44 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Mon, Jan 23, 2012 at 11:36 AM, Yinghai Lu <yinghai@kernel.org> wrote:
>>
>> Maybe we can put VF and PF in bus->devices like:
>> VF come first than PF?
>
> Ugh. Ok, so that's a disgusting hack, but it's better than messing up
> the generic PCI subsystem. At least it's a disgusting hack in the IOV
> code.

just tested, the patch with this hack works.

>
> I still would prefer to just do the virtual devices right instead. Or
> even just make the removal loop inherently robust, rather than have
> that insane knowledge of virtual function devices that were done so
> horribly wrong.

ok, let me think about it more.

>
> Or even just *keep* the virtual devices on the list even though the
> physical device has been removed - make them independent of the
> physical device.

ah, not sure how this going to work.

Yinghai


\
 
 \ /
  Last update: 2012-01-23 22:37    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site