lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 3/4] c/r: procfs: add arg_start/end, env_start/end and exit_code members to /proc/$pid/stat
    On Mon, Jan 23, 2012 at 12:42:28PM -0800, Kees Cook wrote:
    > On Mon, Jan 23, 2012 at 6:20 AM, Cyrill Gorcunov <gorcunov@openvz.org> wrote:
    > > We would like to have an ability to restore command line
    > > arguments and envirion pointers so the task being restored
    > > would print appropriate values in /proc/pid/cmdline and
    > > /proc/pid/envirion. The exit_code is needed to restore
    > > zombie tasks.
    > >
    > > Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
    > > Cc: Pavel Emelyanov <xemul@parallels.com>
    > > Cc: Serge Hallyn <serge.hallyn@canonical.com>
    > > Cc: Kees Cook <keescook@chromium.org>
    > > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    > > Cc: Alexey Dobriyan <adobriyan@gmail.com>
    > > Cc: Tejun Heo <tj@kernel.org>
    > > Cc: Andrew Vagin <avagin@openvz.org>
    > > Cc: Vasiliy Kulikov <segoon@openwall.com>
    > > Cc: Alexey Dobriyan <adobriyan@gmail.com>
    > > Cc: "Eric W. Biederman" <ebiederm@xmission.com>
    > > ---
    > >  fs/proc/array.c |   10 ++++++++--
    > >  1 file changed, 8 insertions(+), 2 deletions(-)
    > >
    > > Index: linux-2.6.git/fs/proc/array.c
    > > ===================================================================
    > > --- linux-2.6.git.orig/fs/proc/array.c
    > > +++ linux-2.6.git/fs/proc/array.c
    > > @@ -464,7 +464,8 @@ static int do_task_stat(struct seq_file
    > >
    > >        seq_printf(m, "%d (%s) %c %d %d %d %d %d %u %lu \
    > >  %lu %lu %lu %lu %lu %ld %ld %ld %ld %d 0 %llu %lu %ld %lu %lu %lu %lu %lu \
    > > -%lu %lu %lu %lu %lu %lu %lu %lu %d %d %u %u %llu %lu %ld %lu %lu %lu\n",
    > > +%lu %lu %lu %lu %lu %lu %lu %lu %d %d %u %u %llu %lu %ld %lu %lu %lu \
    > > +%lu %lu %lu %lu %d\n",
    > >                pid_nr_ns(pid, ns),
    > >                tcomm,
    > >                state,
    > > @@ -514,7 +515,12 @@ static int do_task_stat(struct seq_file
    > >                cputime_to_clock_t(cgtime),
    > >                (mm && permitted) ? mm->start_data : 0,
    > >                (mm && permitted) ? mm->end_data : 0,
    > > -               (mm && permitted) ? mm->start_brk : 0);
    > > +               (mm && permitted) ? mm->start_brk : 0,
    > > +               (mm && permitted) ? mm->arg_start : 0,
    > > +               (mm && permitted) ? mm->arg_end : 0,
    > > +               (mm && permitted) ? mm->env_start : 0,
    > > +               (mm && permitted) ? mm->env_end : 0,
    > > +               task->exit_code);
    > >        if (mm)
    > >                mmput(mm);
    > >        return 0;
    >
    > You're not exposing auxv here? In your testing, what situations ended
    > up using auxv after initial startup? Or is your intention to be able
    > to freeze a process potentially before libc has examined auxv?
    >

    auxv already available via /proc/pid/auxv so I thought it would be
    redundant to put it into different place. Or you meant something
    else?

    In testing I simply read auxv values from /proc/pid/auxv and restore
    them back via prctl at restore time. (prctl patch is in this series
    but it's slightly buggy so I post correct version later).

    And intention is simply dump this vector at checkpoint time and
    restore when needed.

    Cyrill
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-01-23 21:55    [W:0.051 / U:59.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site