lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/17] blkcg: shoot down blkio_groups on elevator switch
On Mon, Jan 23, 2012 at 01:32:07PM -0500, Vivek Goyal wrote:
> This is not just specific to blk-throttle. If in future throttling policy
> is removable like elevator, then it will be fine to reset the throttling
> related configuration upon removal of throttling policy. But resetting
> throttling configuration without policy going anywhere does not sound good.

Yeah, that is a compromise. As long as those configurations are
per-queue, which is the way it's gonna be after the clean up, I don't
think it's a big deal tho. We'll be saying "if you make changes to
the set of blkcg policies applied to a device, all blkcg
configurations regarding the device will be reset" instead of "if any
change to blkcg policies happen system-wide, all blkcg configurations
will be reset", and the former doesn't sound crazy to me. Anyways,
let's see how complex doing the finer grained thing gets.

--
tejun


\
 
 \ /
  Last update: 2012-01-23 19:55    [W:0.262 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site