Messages in this thread | | | Subject | Re: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc_skb | From | Joe Perches <> | Date | Mon, 23 Jan 2012 10:40:34 -0800 |
| |
On Mon, 2012-01-23 at 23:58 +0530, Pradeep A. Dalvi wrote: > Replaced deprecating dev_alloc_skb with netdev_alloc_skb in drivers/net/ethernet > - Removed extra skb->dev = dev after netdev_alloc_skb [] > diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c [] > @@ -871,13 +871,12 @@ lance_init_ring(struct net_device *dev, gfp_t gfp) > struct sk_buff *skb; > void *rx_buff; > > - skb = alloc_skb(PKT_BUF_SZ, GFP_DMA | gfp); > + skb = netdev_alloc_skb(dev, PKT_BUF_SZ);
This change seems suspect. I stopped reading here.
Perhaps you should break this large patch into multiple separate patches.
The trivial, obviously correct and the possibly broken.
| |