lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] NVMe: Fix compilation on architecturs without readq/writeq
    On Mon, Jan 23, 2012 at 8:05 AM, Hitoshi Mitake <h.mitake@gmail.com> wrote:
    >
    > I wrote the patch which adds the new file include/asm-generic/io-nonatomic.h.
    > io-nonatomic.h provides non-atomic version readq()/writeq().

    I do wonder if we should do "little-endian" and "big-endian" variations?

    Quoting Willy:

    "For this particular hardware, it's defined to work if you read the
    low order bits first"

    so I think we need make that explicit, and make two include files:

    include/asm-generic/io-64b-lo-hi.h
    include/asm-generic/io-64b-hi-lo.h

    or something like that. And thus indirectly document these kinds of
    requirements.

    Hmm?

    Linus


    \
     
     \ /
      Last update: 2012-01-23 17:59    [W:0.020 / U:30.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site