Messages in this thread | | | Date | Mon, 23 Jan 2012 11:28:40 -0500 | From | Vivek Goyal <> | Subject | Re: [PATCH 08/17] blkcg: shoot down blkio_groups on elevator switch |
| |
On Mon, Jan 23, 2012 at 08:20:35AM -0800, Tejun Heo wrote: > On Mon, Jan 23, 2012 at 11:13:08AM -0500, Vivek Goyal wrote: > > How about draining throttle groups only on queue exit (blk_cleanup_queue()) > > and not on elevator switch. > > It's for possible policy changes and to fully manage blkg from blkcg. > blkg itself needs to change as applied policies change and need to be > flushed.
Can we avoid integrating everything into single blkg. What's wrong with separate blkg for separage policy. In this case we just don't have the flexbility to change throttling policy. If it is compiled in, it gets activated. The only configurable thing is IO scheduler and these groups will be cleaned up.
So keeping blkg separate for separate policy gives us this flexibility that we don't have to cleanup throttling data and keep the throttling rules persistent across elevator switch.
Thanks Vivek
| |