lkml.org 
[lkml]   [2012]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] staging: zsmalloc: zsmalloc memory allocation library
Hey Andrew, 

Thanks again for responding.

On 01/20/2012 04:12 PM, Andrew Morton wrote:
> On Mon, 9 Jan 2012 16:51:56 -0600
> Seth Jennings <sjenning@linux.vnet.ibm.com> wrote:
>
>> This patch creates a new memory allocation library named
>> zsmalloc.
>
> I haven't really begun to look at this yet. The code is using many
> fields of struct page in new ways. This is key information for anyone
> to effectively review the code. So please carefully document (within
> the code itself) the ways in which the various page fields are used:
> semantic meaning of the overload, relationships between them, any
> locking rules or assumptions.

Will do.

> It appears that a pile of dead code will be generated if CPU hotplug is
> disabled. (That's if it compiles at all!). Please take a look at users
> of hotcpu_notifier() - this facility cunningly causes all the hotplug code
> to vanish from vmlinux if it is unneeded.

I'll take a look at hotcpu_notifier() users. Thanks.

> afacit this code should be added to core mm/. Addition of code like
> this to core mm/ will be fiercely resisted on principle! Hence the
> (currently missing) justifications for adding it had best be good ones.

Thanks for the insight. I'll put some work into spelling out the benefits
this code provides that are not currently provided by any other code in the
kernel right now (afaik).

If you think this belongs in mm/ then disregard my previous comment in
the response to the cover letter. I guess I was leaning toward putting it
in lib/ specifically because I knew that it would be hard to get it into mm/.

Thanks
--
Seth



\
 
 \ /
  Last update: 2012-01-23 15:41    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site