lkml.org 
[lkml]   [2012]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: i915/kms/backlight-combo mode problem

> Here's a patch which just flips the interpretation of that value over;
> does this work?
>
> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> index 04d79fd..43faa9d 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -207,6 +207,7 @@ u32 intel_panel_get_backlight(struct drm_device *dev)
> u8 lbpc;
>
> pci_read_config_byte(dev->pdev, PCI_LBPC,&lbpc);
> + lbpc = 0xff - lbpc;
> val *= lbpc;
> }
> }
> @@ -238,7 +239,7 @@ static void intel_panel_actually_set_backlight(struct drm_device *dev, u32 level
>
> lbpc = level * 0xfe / max + 1;
> level /= lbpc;
> - pci_write_config_byte(dev->pdev, PCI_LBPC, lbpc);
> + pci_write_config_byte(dev->pdev, PCI_LBPC, 0xff - lbpc);
> }
>
> tmp = I915_READ(BLC_PWM_CTL);
This works - the backlight stays on, and can be switched off with Fn-F6.
Interestingly the values for setpci -s are still *exactly the same*, as
in 0x00 is fully on, 0xFF is off (with graduation in between), despite
the values being reversed.

Chris.


\
 
 \ /
  Last update: 2012-01-22 11:49    [W:0.799 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site