lkml.org 
[lkml]   [2012]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] netdev/ethernet: dev_alloc_skb to netdev_alloc_skb
From
On Sun, Jan 22, 2012 at 12:09 AM, David Miller <davem@davemloft.net> wrote:
> From: "Pradeep A. Dalvi" <netdev@pradeepdalvi.com>
> Date: Sat, 21 Jan 2012 22:16:06 +0530
>
>> I appreciate your concerns. Although I feel, it is essential to add
>> relevant comments by respective (corporate/paid :-) developers, if
>> their hardware needs hardcoded 2. And especially, if their expectation
>> is to buy their hardware, even for the smaller purpose of having
>> uniform mechanism. Long live Open Source! :-)
>
> I see the smiley but it is your responsibility to learn how a driver
> works before making changes to it that break them.  Stop talking such
> foolishness, it is very unbecoming of a serious developer.

Certainly! I completely agree to the point of being responsible
contributor and in another words, not to break existing things due to
lack of information.
Although I mentioned so, due to realized importance of
comments/documentation over the expectations of owning hardware for
testing. Especially, if those points are so much critical to the
hardware. And also more importantly, while accessing Kernel resources.
Anyways, I would avoid touching +2 further, like I've avoided for +3,
+4, +5 and so on, in this patch & resubmit the patch. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-01-21 20:21    [W:0.459 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site