Messages in this thread Patch in this message | | | Date | Fri, 20 Jan 2012 17:43:54 +0530 | From | Srikar Dronamraju <> | Subject | [PATCH] [TRIVIAL] perf probe usability related fixes. |
| |
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Ingo pointed out few perf probe usability related errors during his review of uprobes.
Since these issues are independent of uprobes, fixing them in a separate patch.
Suggested-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> --- tools/perf/util/probe-event.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index f6f5794..da38ec5 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -1825,7 +1825,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev, } ret = 0; - printf("Add new event%s\n", (ntevs > 1) ? "s:" : ":"); + printf("Added new event%s\n", (ntevs > 1) ? "s:" : ":"); for (i = 0; i < ntevs; i++) { tev = &tevs[i]; if (pev->event) @@ -1880,7 +1880,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev, if (ret >= 0) { /* Show how to use the event. */ - printf("\nYou can now use it on all perf tools, such as:\n\n"); + printf("\nYou can now use it in all perf tools, such as:\n\n"); printf("\tperf record -e %s:%s -aR sleep 1\n\n", tev->group, tev->event); } @@ -2063,7 +2063,7 @@ static int __del_trace_probe_event(int fd, struct str_node *ent) goto error; } - printf("Remove event: %s\n", ent->s); + printf("Removed event: %s\n", ent->s); return 0; error: pr_warning("Failed to delete event: %s\n", strerror(-ret));
| |