Messages in this thread Patch in this message |  | | | From | Namhyung Kim <> | | Subject | [PATCH 1/2] perf: Don't call release_callchain_buffers if alloc fails | | Date | Fri, 20 Jan 2012 10:12:45 +0900 |
| |
When alloc_callchain_buffers() fails, it frees all of entries before return. In addition, calling the release_callchain_buffers() will cause a NULL pointer dereference since callchain_cpu_entries is not set.
Signed-off-by: Namhyung Kim <namhyung.kim@lge.com> --- kernel/events/callchain.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c index 057e24b665cf..6581a040f399 100644 --- a/kernel/events/callchain.c +++ b/kernel/events/callchain.c @@ -115,8 +115,6 @@ int get_callchain_buffers(void) } err = alloc_callchain_buffers(); - if (err) - release_callchain_buffers(); exit: mutex_unlock(&callchain_mutex); -- 1.7.9.rc1.dirty
|  |