lkml.org 
[lkml]   [2012]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/12] blkcg: use the usual get blkg path for root blkio_group
Hello,

On Thu, Jan 19, 2012 at 09:41:36AM -0500, Vivek Goyal wrote:
> > This simplifies root blkg handling noticeably for cfq and will allow
> > further modularization of blkcg API.
>
> Does this work if BLK_CGROUP=n?
>
> I am trying to think that why did I keep allocating root cgroup statically
> for CFQ. May be the reason was that this group was present even if
> CFQ_GROUP_IOSCHED=n. There was other code which assumed a group to be
> always present and I did not want to put more #ifdef.
>
> Anyway, if it works well, with BLK_CGROUP=n, then it is fine.

Right, it's currently broken but it shouldn't be too difficult to fix.
Will update the patch.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2012-01-19 17:19    [from the cache]
©2003-2011 Jasper Spaans