lkml.org 
[lkml]   [2012]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/8] dmaengine/dw_dmac: Unmap all memory buffers after completion of slave transfers
    On Tue, Jan 17, 2012 at 02:37:10PM +0530, Viresh Kumar wrote:
    > On 1/17/2012 2:22 PM, Linus Walleij wrote:
    > > Basically the driver using the dmaengine shall map/unmap buffers
    > > used for slave transfers, not the driver.
    > >
    > > I usually map them before setting up a transfer and unmaps them
    > > when egtting the callback from the DMA engine that the transfer is
    > > complete.
    > >
    >
    > You implemented similar stuff in amba-pl08x :) .
    >
    > if (!plchan->slave)
    > pl08x_unmap_buffers(txd);

    Take a look at that. "If *NOT* slave, unmap the buffers". That is in
    keeping with what I've been saying. Slave transfers *do* *not* get
    automatic buffer unmapping.


    \
     
     \ /
      Last update: 2012-01-18 10:39    [W:0.116 / U:29.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site