lkml.org 
[lkml]   [2012]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] eCryptfs: infinite loop bug
    On Wed, Jan 18, 2012 at 1:40 PM, Tyler Hicks <tyhicks@canonical.com> wrote:
    >
    > mm/filemap.c uses unsigned long for variables used to identify an offset
    > into a single page. That's what I'm tempted to use for offset_in_page,
    > rather than loff_t.

    Indeed. The offset within a page will fit fine even in an "unsigned
    int", and "loff_t" is crazy overkill - and usually generates horrible
    code on 32-bit architectures.

    Linus


    \
     
     \ /
      Last update: 2012-01-19 04:45    [W:0.020 / U:58.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site