Messages in this thread | | | Date | Wed, 18 Jan 2012 14:16:02 -0800 | Subject | Re: [PATCH v5] ramoops: use pstore interface | From | Kees Cook <> |
| |
On Wed, Jan 18, 2012 at 2:06 PM, Andrew Morton <akpm@linux-foundation.org> wrote: > On Tue, 17 Jan 2012 15:58:52 -0800 > Kees Cook <keescook@chromium.org> wrote: > >> --- a/drivers/char/Kconfig >> +++ b/drivers/char/Kconfig >> @@ -603,6 +603,7 @@ source "drivers/s390/char/Kconfig" >> config RAMOOPS >> tristate "Log panic/oops to a RAM buffer" >> depends on HAS_IOMEM >> + depends on PSTORE >> default n >> help >> This enables panic and oops messages to be logged to a circular > > I think this is the right thing to do, but boy I hate it. You sit > there wondering "wtf do I need to enable so I can use feature X". I > sometimes use menuconfig's search feature, other times go trawl the > Kconfig files. There should be a capability in Kconfig to just turn on > the terminal feature, enabling any precondition features on the way. > Everyone loves Kconfig.
Heh. Yeah, makes a lot of thing undiscoverable in menuconfig. Maybe stuff should be greyed out instead of just disappearing.
>> static int __exit ramoops_remove(struct platform_device *pdev) >> { >> +#if 0 >> + /* TODO(kees): We cannot unload ramoops since pstore doesn't support >> + * unregistering yet. >> + */ > > Well that sucks. Is pstore getting fixed?
Tony, any plans for changing this? I'm ready when it does! :)
Thanks,
-Kees
-- Kees Cook ChromeOS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |