lkml.org 
[lkml]   [2012]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] drm/i915: Use kcalloc instead of kzalloc to allocate array
    On Tue, Nov 29, 2011 at 10:08:00PM +0100, Thomas Meyer wrote:
    > The advantage of kcalloc is, that will prevent integer overflows which could
    > result from the multiplication of number of elements and size and it is also
    > a bit nicer to read.
    >
    > The semantic patch that makes this change is available
    > in https://lkml.org/lkml/2011/11/25/107
    >
    > Signed-off-by: Thomas Meyer <thomas@m3y3r.de>

    Queued for -next, thanks for the patch.
    -Daniel

    > ---
    >
    > diff -u -p a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
    > --- a/drivers/gpu/drm/i915/intel_bios.c 2011-11-13 11:07:23.820113543 +0100
    > +++ b/drivers/gpu/drm/i915/intel_bios.c 2011-11-28 19:49:51.443206904 +0100
    > @@ -572,7 +572,7 @@ parse_device_mapping(struct drm_i915_pri
    > DRM_DEBUG_KMS("no child dev is parsed from VBT\n");
    > return;
    > }
    > - dev_priv->child_dev = kzalloc(sizeof(*p_child) * count, GFP_KERNEL);
    > + dev_priv->child_dev = kcalloc(count, sizeof(*p_child), GFP_KERNEL);
    > if (!dev_priv->child_dev) {
    > DRM_DEBUG_KMS("No memory space for child device\n");
    > return;
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > http://lists.freedesktop.org/mailman/listinfo/dri-devel

    --
    Daniel Vetter
    Mail: daniel@ffwll.ch
    Mobile: +41 (0)79 365 57 48


    \
     
     \ /
      Last update: 2012-01-17 17:35    [W:0.023 / U:0.204 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site