Messages in this thread | | | Date | Tue, 17 Jan 2012 13:49:02 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH -tip v4 1/5] perf-script: unify the expressions indicate "unknown" |
| |
Em Mon, Jan 16, 2012 at 02:22:10PM +0900, Akihiro Nagai escreveu: > perf-script uses various expressions to indicate "unknown". > It is unfriendly for user scripts to parse it. So, this patch unifies > the expressions to "[unknown]".
> diff --git a/tools/perf/util/map.h b/tools/perf/util/map.h > @@ -118,6 +118,7 @@ void map__delete(struct map *self); > size_t map__fprintf(struct map *self, FILE *fp); > +void map__print_dsoname(struct map *self);
See map__fprintf(), everything that is for printing to a file like output has that form: last paramenter is a FILE pointer, then users do:
map__fprintf_dsoname(map, stdout);
or to stderr, or to something else, like in cases where tools have a 'strace -o FILENAME' like switch, like 'perf stat --log-fd N':
OPT_INTEGER(0, "log-fd", &output_fd, "log output to fd, instead of stderr"),
That uses fdreopen(output_fd), etc.
So please convert these new __print_something methods to __fprintf_something(..., FILE *fp).
Also please don't use 'self' anymore, that was a bad decision I made in perf's early ages and that Thomas Gleixner suggested we use more descriptive names such as, in the above case, 'map', i.e.:
void map__fprintf_dsoname(struct map *map, FILE *fp);
From time to time I convert these 'self' leftovers in areas where I notice that are not having too much coding activity, to avoid clashing with pending patches, so lets not add more in new code :)
Thanks,
- Arnaldo
| |