Messages in this thread | | | Subject | Re: [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface | From | Steven Rostedt <> | Date | Mon, 16 Jan 2012 21:07:35 -0500 |
| |
On Tue, 2012-01-17 at 02:42 +0100, Frederic Weisbecker wrote: > > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > > index 523640f..0d43a2b 100644 > > --- a/include/linux/ftrace.h > > +++ b/include/linux/ftrace.h > > @@ -35,12 +35,14 @@ enum { > > FTRACE_OPS_FL_ENABLED = 1 << 0, > > FTRACE_OPS_FL_GLOBAL = 1 << 1, > > FTRACE_OPS_FL_DYNAMIC = 1 << 2, > > + FTRACE_OPS_FL_CONTROL = 1 << 3, > > Please comment the role of this flag. In fact it would be nice to have > a comment that explains all these. GLOBAL and DYNAMIC don't actually give > much clues alone.
Someone else asked about commenting these (was it you?). I probably should, as it is confusing to what they are used for.
I just figured every just figures it out by looking at the code ;-)
-- Steve
| |