Messages in this thread |  | | | Date | Mon, 16 Jan 2012 16:15:48 -0800 | | From | Greg KH <> | | Subject | Re: [PATCH] mce: fix warning messages about static struct mce_device |
| |
On Tue, Jan 17, 2012 at 01:14:03AM +0100, Djalal Harouni wrote: > On Mon, Jan 16, 2012 at 02:40:28PM -0800, Greg KH wrote: > > From: Greg Kroah-Hartman <gregkh@suse.de> > > > > When suspending, there was a large list of warnings going something like: > Not only suspend, during poweroff we'll also see these annoying warnings > as reported here: http://lkml.org/lkml/2012/1/10/504
Ah, yes, I forgot about that case.
> > Device 'machinecheck1' does not have a release() function, it is broken and must be fixed > > > > This patch turns the static mce_devices into dynamically allocated, and > > properly frees them when they are removed from the system. It solves > > the warning messages on my laptop here. > > > > Reported-by: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com> > > Reported-by: Linus Torvalds <torvalds@linux-foundation.org> > > Cc: Kay Sievers <kay.sievers@vrfy.org> > > Cc: Tony Luck <tony.luck@intel.com> > > Cc: Borislav Petkov <bp@amd64.org> > > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> > > > > --- > > > > Linus, this should fix the warnings on your laptop, it does on mine. > Patch tested. > > Thanks, this also fixed the warnings for my KVM/Qemu guests.
Wonderful, thanks for testing.
Linus, do you want to take this directly from the email, or do you want me to put it in a tree to pull from?
thanks,
greg k-h
|  |