Messages in this thread | | | Date | Mon, 16 Jan 2012 12:18:43 -0500 | From | Naoya Horiguchi <> | Subject | Re: [PATCH 1/6] pagemap: avoid splitting thp when reading /proc/pid/pagemap |
| |
On Sun, Jan 15, 2012 at 01:06:05PM +0100, Andrea Arcangeli wrote: > On Sat, Jan 14, 2012 at 06:00:26PM +0100, Andrea Arcangeli wrote: > > Why don't you pass the pmd and then do "if (pmd_present(pmd)) > > page_to_pfn(pmd_page(pmd)) ? What's the argument for the cast. I'm > > Of course I meant pmd_pfn above... in short as a replacement of the > pte_pfn in your patch. > > About the _stable function, I was now thinking maybe _lock suffix is > more appropriate than _stable, because that function effectively has > the objective of taking the page_table_lock in the most efficient way, > and not much else other than taking the lock. Adding a comment that > it's only safe to call with the mmap_sem held in the inline version in > the .h file (the one that then would call the __ version in the .c > file).
OK, I will use _lock suffix and add the comment in the next post.
| |