lkml.org 
[lkml]   [2012]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] mm: memcg: update the correct soft limit tree during migration
On Fri, Jan 13, 2012 at 04:41:31PM +0100, Johannes Weiner wrote:
> end_migration() passes the old page instead of the new page to commit
> the charge. This page descriptor is not used for committing itself,
> though, since we also pass the (correct) page_cgroup descriptor. But
> it's used to find the soft limit tree through the page's zone, so the
> soft limit tree of the old page's zone is updated instead of that of
> the new page's, which might get slightly out of date until the next
> charge reaches the ratelimit point.
>
> This glitch has been present since '5564e88 memcg: condense
> page_cgroup-to-page lookup points'.
>
> Reported-by: Hugh Dickins <hughd@google.com>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Acked-by: Kirill A. Shutemov <kirill@shutemov.name>


--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2012-01-16 13:45    [W:0.963 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site