lkml.org 
[lkml]   [2012]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [GIT PULL] target: Updates for v3.3-rc1 (round 1)
From
Date
On Wed, 2012-01-11 at 05:49 -0500, Christoph Hellwig wrote:
> On Tue, Jan 10, 2012 at 01:51:07PM -0600, James Bottomley wrote:
> > > The changes since the Nov 4 RFC are listed in the patch commit log:
> > >
> > > ib_srpt: Make compilation with BUG=n proceed`
> > > ib_srpt: Use new target_core_fabric.h include
> > > ib_srpt: Check hex2bin() return code to silence build warning
> > >
> > > These are all very minor and did not warrant another full RFC posting.
> >
> > They might not warrant a full RFC reposting, but individually they
> > should have been posted to the list, so Bart is right.
>
> At least 2 and 3 list, just not as global patches against the
> target tree, not ib_srpt specificly:
>
> 2 is from: [PATCH] target: header reshuffle, part2
> 3 is from: [PATCH 5/5] target: check hex2bin result
>
> Not sure about 1.
>
> I'm really getting tired of this bickering. It's a brand new driver and
> doesn't have to be perfect. While Bart generally has technically good
> points there's really no reason to put his remaining fixups in after
> the driver has been merged and available to a wieder audience.

Absolutely. I was just reminding about git best practises, not NAKing a
pull. Putting this in the kernel and sorting out the rough edges later
is fine by me ... just make sure the rough edges go over the list ...

James




\
 
 \ /
  Last update: 2012-01-14 16:23    [W:1.428 / U:1.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site