Messages in this thread | | | Date | Sat, 14 Jan 2012 00:14:30 -0800 (PST) | Subject | Re: [PATCH] pch_gbe: Use a randomly generated MAC instead of failing probe | From | David Miller <> |
| |
From: Darren Hart <dvhart@linux.intel.com> Date: Fri, 13 Jan 2012 22:44:55 -0800
> If the MAC is invalid or not implemented, use a randomly generated one rather > than failing the probe. Store the generated addr in a new sw_mac array in the > pch_gbe_mac_info structure. Take care to allow for assigning the MAC via > ifconfig by reusing sw_addr to store an assigned mac if probe populated it with > a random one (otherwise the assignment would rely on the ROM and the reset would > fail to write a valid MAC to the rx filter). > > Tested on two platforms, one with a valid MAC, the other without a MAC. The > real MAC is used if present, a randomly generated one otherwise. Both are > capable of changing the MAC with ifconfig. They successfully get an IP over > DHCP and pass a simple ping and login over ssh test. > > This does not make any attempt to address a missing or invalid MAC for the > pch_phub driver. > > Signed-off-by: Darren Hart <dvhart@linux.intel.com>
I don't want to see code like this added if it's "just in case."
Please correct any hardware that hasn't shipped yet or is alpha/beta hardware in testing, so that we don't need stuff like this.
| |