lkml.org 
[lkml]   [2012]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] gpu, drm, sis: Don't return uninitialized variable from sis_driver_load()
On Sat, Jan 14, 2012 at 09:20:37PM +0100, Jesper Juhl wrote:
> In sis_driver_load(), the only use of 'ret' is as the return value
> from the function, unfortunately it is never initialized, so the
> function just returns garbage when it succeeds.
> To fix that, remove the variable and just return 0 directly on success.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Woot, not one of mine!

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48


\
 
 \ /
  Last update: 2012-01-15 01:11    [W:0.039 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site