lkml.org 
[lkml]   [2012]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [git pull] PCI changes
    On Fri, Jan 13, 2012 at 1:24 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
    >>
    >> So why is acpi_pci_root_add() special? Cna you explain that part to me?
    >
    > pcie_no_aspm() means "Do not permit ASPM to be enabled" - it doesn't
    > alter the existing state. pcie_clear_aspm() does that.

    I *know*.

    So look again.

    Why is acpi_pci_root_add() special?

    Because dammit, it does exactly that pcie_clear_aspm() for the
    ACPI_FADT_NO_ASPM case.

    That was my question. Why does it do that, when the commit log (and
    the other users) say that ACPI_FADT_NO_ASPM means "don't touch".

    It touches.

    Linus


    \
     
     \ /
      Last update: 2012-01-14 00:17    [W:0.030 / U:31.564 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site