lkml.org 
[lkml]   [2012]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/2] cuse: implement memory mapping
    On Fri, Jan 13, 2012 at 9:06 AM, Miklos Szeredi <miklos@szeredi.hu> wrote:
    > From: Tejun Heo <htejun@gmail.com>
    >
    > This implements memory mapping of char devices.

    I don't think this is how you want to do it.

    It seems to maintain a page list of its own, and do the magic page
    fault etc behavior. Which to me smells like a really bad design.

    I would expect that what you actually want to do is to expose it as a
    shared mmap, and depend on all the normal shmem support. Is there any
    reason not to do that?

    I guess you don't generally have big mappings, so an argument like
    "that way you can page out pages etc" may not strike you as a very
    strong argument, but I'd still prefer to at least see that approach
    explored. Hmm?

    Linus


    \
     
     \ /
      Last update: 2012-01-13 19:23    [W:0.022 / U:90.472 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site