Messages in this thread | | | Date | Fri, 13 Jan 2012 21:35:54 +0800 | From | Shawn Guo <> | Subject | Re: [RFC PATCH v3 2/5] pinctrl: add dt binding support for pinmux mappings |
| |
On Fri, Jan 13, 2012 at 08:07:35AM +0000, Dong Aisheng-B29396 wrote: > > > But, one thought on doing this in pinmux_get(). I'd simply implement a > > > Function that read a DT node's pinmux property/node, converted it to a > > > pinmux mapping table, and registered it with the pinctrl core. Then, > > > pinmux_get() could simply call this before doing anything else at all. > > > I don't think you'd need to modify how pinmux_get() worked at all. > > > > > This sounds like a pretty good idea to me. > > > This does not fix the inconsistency issue. > Additionally as I said before, for better support dynamically register pinmux > Map, it looks we'd better change the pinmux_maps array to a list. > However this is for dt case. > But for non-dt case, the static array is just ok. > So there's conflict. > Not sure if any better idea to fix this. > My guess is that Linus.W did not get any chance to take the dt case into account with his first design of pinctrl core. But I guess he is open to any reasonable change to pinctrl core for dt adoption. Linus?
-- Regards, Shawn
| |